Conversation
jacobgkau
force-pushed
the
major-n4
branch
3 times, most recently
from
b2b6bc8 to
00d2d7a
Compare
* Correct numbering in GPU (brace) & CPU cooler sections * Spare 2.5" screws also require removing right side panel * Update Mira model number in Thelio Io board parts section * Rename heatsink -> radiator in top shell section * Fix broken side panel link in side fan section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the Thelio Major R5-N4's service manual to tech docs. Some of the photos look a little rougher than the Mira R4-N4 section since the Major R5-N4 photo unit was a heavily used R&D unit.
I also corrected a number of problems I found in the Thelio Mira R4-N4 section's text while working on the R5-N4 section.
Changing .md to .mdx for certain pages
This also corrects an issue with ampersands in image alt/title attributes. Astro was not rendering them properly:
This seems to have to do with Astro's various (pre)processors for Markdown, HTML, etc. I'm not sure if it's technically a bug or not, but no amount of manual escaping or using alternative HTML codes for the & character was able to work around it. It appears the simplest way to correct it is just to use .mdx instead, which uses a more sophisticated preprocessor that doesn't have this problem:
So I've gone ahead and converted all pages with an & inside an image alt/title attribute to .mdx (it's usually just a matter of renaming the file, as most valid Markdown syntax is also valid MDX syntax).
While working on that, I found a gap in our documentation regarding cleaning up after what's built by the devcontainer setup, so I also added that to the README.